1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
use log::debug;
use sp_runtime::SaturatedConversion;

use crate::{
    phron_primitives::BlockNumber,
    data_io::{
        chain_info::ChainInfoProvider,
        legacy::proposal::{PhronProposal, PendingProposalStatus, ProposalStatus},
    },
};

pub fn get_proposal_status<CIP>(
    chain_info_provider: &mut CIP,
    proposal: &PhronProposal,
    old_status: Option<&ProposalStatus>,
) -> ProposalStatus
where
    CIP: ChainInfoProvider,
{
    use PendingProposalStatus::*;
    use ProposalStatus::*;

    let current_highest_finalized = chain_info_provider.get_highest_finalized().number;

    if current_highest_finalized >= proposal.number_top_block() {
        return Ignore;
    }

    if is_hopeless_fork(chain_info_provider, proposal) {
        debug!(target: "phron-finality", "Encountered a hopeless fork proposal {:?}.", proposal);
        return Ignore;
    }

    let old_status = match old_status {
        Some(status) => status,
        None => &Pending(PendingTopBlock),
    };
    match old_status {
        Pending(PendingTopBlock) => {
            let top_block = proposal.top_block();
            if chain_info_provider.is_block_imported(&top_block) {
                // Note that the above also makes sure that the `number` claimed in the proposal is correct.
                // That's why checking the branch correctness now boils down to checking the parent-child
                // relation on the branch.
                if is_branch_ancestry_correct(chain_info_provider, proposal) {
                    if is_ancestor_finalized(chain_info_provider, proposal) {
                        Finalize(
                            proposal
                                .blocks_from_num(current_highest_finalized + 1)
                                .collect(),
                        )
                    } else {
                        // This could also be a hopeless fork, but we have checked before that it isn't (yet).
                        Pending(TopBlockImportedButNotFinalizedAncestor)
                    }
                } else {
                    // This could also be a hopeless fork, but we have checked before that it isn't (yet).
                    Pending(TopBlockImportedButIncorrectBranch)
                }
            } else {
                // This could also be a hopeless fork, but we have checked before that it isn't (yet).
                Pending(PendingTopBlock)
            }
        }
        Pending(TopBlockImportedButNotFinalizedAncestor) => {
            if is_ancestor_finalized(chain_info_provider, proposal) {
                Finalize(
                    proposal
                        .blocks_from_num(current_highest_finalized + 1)
                        .collect(),
                )
            } else {
                // This could also be a hopeless fork, but we have checked before that it isn't (yet).
                Pending(TopBlockImportedButNotFinalizedAncestor)
            }
        }
        Pending(TopBlockImportedButIncorrectBranch) => {
            // This could also be a hopeless fork, but we have checked before that it isn't (yet).
            Pending(TopBlockImportedButIncorrectBranch)
        }
        _ => old_status.clone(),
    }
}

fn is_hopeless_fork<CIP>(chain_info_provider: &mut CIP, proposal: &PhronProposal) -> bool
where
    CIP: ChainInfoProvider,
{
    let bottom_num = proposal.number_bottom_block();
    for i in 0..proposal.len() {
        if let Ok(finalized_block) =
            chain_info_provider.get_finalized_at(bottom_num + <BlockNumber>::saturated_from(i))
        {
            if finalized_block.hash != proposal[i] {
                return true;
            }
        } else {
            // We don't know the finalized block at this height
            break;
        }
    }
    false
}

fn is_ancestor_finalized<CIP>(chain_info_provider: &mut CIP, proposal: &PhronProposal) -> bool
where
    CIP: ChainInfoProvider,
{
    let bottom = proposal.bottom_block();
    let parent_hash = if let Ok(hash) = chain_info_provider.get_parent_hash(&bottom) {
        hash
    } else {
        return false;
    };
    let finalized =
        if let Ok(hash) = chain_info_provider.get_finalized_at(proposal.number_below_branch()) {
            hash
        } else {
            return false;
        };
    parent_hash == finalized.hash
}

// Checks that the subsequent blocks in the branch are in the parent-child relation, as required.
fn is_branch_ancestry_correct<CIP>(chain_info_provider: &mut CIP, proposal: &PhronProposal) -> bool
where
    CIP: ChainInfoProvider,
{
    let bottom_num = proposal.number_bottom_block();
    for i in 1..proposal.len() {
        let curr_num = bottom_num + <BlockNumber>::saturated_from(i);
        let curr_block = proposal.block_at_num(curr_num).expect("is within bounds");
        match chain_info_provider.get_parent_hash(&curr_block) {
            Ok(parent_hash) => {
                if parent_hash != proposal[i - 1] {
                    return false;
                }
            }
            Err(()) => {
                return false;
            }
        }
    }
    true
}

#[cfg(test)]
mod tests {
    use std::{num::NonZeroUsize, sync::Arc};

    use sp_runtime::traits::Block as BlockT;

    use crate::{
        data_io::{
            chain_info::{
                AuxFinalizationChainInfoProvider, CachedChainInfoProvider,
                SubstrateChainInfoProvider,
            },
            proposal::{
                PhronProposal,
                PendingProposalStatus::*,
                ProposalStatus::{self, *},
            },
            status_provider::get_proposal_status,
            ChainInfoCacheConfig, MAX_DATA_BRANCH_LEN,
        },
        testing::{
            client_chain_builder::ClientChainBuilder,
            mocks::{
                unvalidated_proposal_from_headers, TBlock, THeader, TestClient, TestClientBuilder,
                TestClientBuilderExt,
            },
        },
        SessionBoundaryInfo, SessionId, SessionPeriod,
    };

    // A large number only for the purpose of creating `PhronProposal`s
    const DUMMY_SESSION_LEN: u32 = 1_000_000;

    fn proposal_from_headers(headers: Vec<THeader>) -> PhronProposal {
        let unvalidated = unvalidated_proposal_from_headers(headers);
        let session_boundaries = SessionBoundaryInfo::new(SessionPeriod(DUMMY_SESSION_LEN))
            .boundaries_for_session(SessionId(0));
        unvalidated.validate_bounds(&session_boundaries).unwrap()
    }

    fn proposal_from_blocks(blocks: Vec<TBlock>) -> PhronProposal {
        let headers = blocks.into_iter().map(|b| b.header().clone()).collect();
        proposal_from_headers(headers)
    }

    type TestCachedChainInfo =
        CachedChainInfoProvider<SubstrateChainInfoProvider<TBlock, TestClient>>;
    type TestAuxChainInfo =
        AuxFinalizationChainInfoProvider<SubstrateChainInfoProvider<TBlock, TestClient>>;

    fn prepare_proposal_test() -> (ClientChainBuilder, TestCachedChainInfo, TestAuxChainInfo) {
        let client = Arc::new(TestClientBuilder::new().build());

        let config = ChainInfoCacheConfig {
            block_cache_capacity: NonZeroUsize::new(2).unwrap(),
        };
        let cached_chain_info_provider =
            CachedChainInfoProvider::new(SubstrateChainInfoProvider::new(client.clone()), config);

        let chain_builder =
            ClientChainBuilder::new(client.clone(), Arc::new(TestClientBuilder::new().build()));

        let aux_chain_info_provider = AuxFinalizationChainInfoProvider::new(
            SubstrateChainInfoProvider::new(client),
            chain_builder.genesis_hash_num(),
        );

        (
            chain_builder,
            cached_chain_info_provider,
            aux_chain_info_provider,
        )
    }

    fn verify_proposal_status(
        cached_cip: &mut TestCachedChainInfo,
        aux_cip: &mut TestAuxChainInfo,
        proposal: &PhronProposal,
        correct_status: ProposalStatus,
    ) {
        let status_a = get_proposal_status(aux_cip, proposal, None);
        assert_eq!(
            status_a, correct_status,
            "Aux chain info gives wrong status for proposal {proposal:?}"
        );
        let status_c = get_proposal_status(cached_cip, proposal, None);
        assert_eq!(
            status_c, correct_status,
            "Cached chain info gives wrong status for proposal {proposal:?}"
        );
    }

    fn verify_proposal_of_all_lens_finalizable(
        blocks: Vec<TBlock>,
        cached_cip: &mut TestCachedChainInfo,
        aux_cip: &mut TestAuxChainInfo,
    ) {
        for len in 1..=MAX_DATA_BRANCH_LEN {
            let blocks_branch = blocks[0..len].to_vec();
            let proposal = proposal_from_blocks(blocks_branch);
            verify_proposal_status(
                cached_cip,
                aux_cip,
                &proposal,
                ProposalStatus::Finalize(proposal.blocks_from_num(0).collect()),
            );
        }
    }

    #[tokio::test]
    async fn correct_proposals_are_finalizable_even_with_forks() {
        let (mut chain_builder, mut cached_cip, mut aux_cip) = prepare_proposal_test();
        let blocks = chain_builder
            .initialize_single_branch_and_import(MAX_DATA_BRANCH_LEN * 10)
            .await;

        verify_proposal_of_all_lens_finalizable(blocks.clone(), &mut cached_cip, &mut aux_cip);

        let _fork = chain_builder
            .build_and_import_branch_above(&blocks[2].header.hash(), MAX_DATA_BRANCH_LEN * 10)
            .await;

        verify_proposal_of_all_lens_finalizable(blocks.clone(), &mut cached_cip, &mut aux_cip);
    }

    #[tokio::test]
    async fn not_finalized_ancestors_handled_correctly() {
        let (mut chain_builder, mut cached_cip, mut aux_cip) = prepare_proposal_test();
        let blocks = chain_builder
            .initialize_single_branch_and_import(MAX_DATA_BRANCH_LEN * 10)
            .await;

        let fork = chain_builder
            .build_and_import_branch_above(&blocks[2].header.hash(), MAX_DATA_BRANCH_LEN * 10)
            .await;

        for len in 1..=MAX_DATA_BRANCH_LEN {
            let blocks_branch = blocks[1..(len + 1)].to_vec();
            let proposal = proposal_from_blocks(blocks_branch);
            verify_proposal_status(
                &mut cached_cip,
                &mut aux_cip,
                &proposal,
                Pending(TopBlockImportedButNotFinalizedAncestor),
            );
            let blocks_branch = fork[1..(len + 1)].to_vec();
            let proposal = proposal_from_blocks(blocks_branch);
            verify_proposal_status(
                &mut cached_cip,
                &mut aux_cip,
                &proposal,
                Pending(TopBlockImportedButNotFinalizedAncestor),
            );
        }
    }

    #[tokio::test]
    async fn incorrect_branch_handled_correctly() {
        let (mut chain_builder, mut cached_cip, mut aux_cip) = prepare_proposal_test();
        let blocks = chain_builder
            .initialize_single_branch_and_import(MAX_DATA_BRANCH_LEN * 10)
            .await;

        let incorrect_branch = vec![
            blocks[0].clone(),
            blocks[1].clone(),
            blocks[3].clone(),
            blocks[5].clone(),
        ];
        let proposal = proposal_from_blocks(incorrect_branch);
        verify_proposal_status(
            &mut cached_cip,
            &mut aux_cip,
            &proposal,
            Pending(TopBlockImportedButIncorrectBranch),
        );

        chain_builder.finalize_block(&blocks[1].header.hash());
        verify_proposal_status(
            &mut cached_cip,
            &mut aux_cip,
            &proposal,
            Pending(TopBlockImportedButIncorrectBranch),
        );

        chain_builder.finalize_block(&blocks[10].header.hash());
        verify_proposal_status(&mut cached_cip, &mut aux_cip, &proposal, Ignore);
    }

    #[tokio::test]
    async fn pending_top_block_handled_correctly() {
        let (mut chain_builder, mut cached_cip, mut aux_cip) = prepare_proposal_test();
        let blocks = chain_builder
            .initialize_single_branch(MAX_DATA_BRANCH_LEN * 10)
            .await;

        for len in 1..=MAX_DATA_BRANCH_LEN {
            let blocks_branch = blocks[0..len].to_vec();
            let proposal = proposal_from_blocks(blocks_branch);
            verify_proposal_status(
                &mut cached_cip,
                &mut aux_cip,
                &proposal,
                Pending(PendingTopBlock),
            );
        }
        chain_builder.import_branch(blocks.clone()).await;

        verify_proposal_of_all_lens_finalizable(blocks, &mut cached_cip, &mut aux_cip);
    }

    #[tokio::test]
    async fn hopeless_forks_handled_correctly() {
        let (mut chain_builder, mut cached_cip, mut aux_cip) = prepare_proposal_test();
        let blocks = chain_builder
            .initialize_single_branch_and_import(MAX_DATA_BRANCH_LEN * 10)
            .await;

        let fork = chain_builder
            .build_branch_above(&blocks[2].header.hash(), MAX_DATA_BRANCH_LEN * 10)
            .await;

        for len in 1..=MAX_DATA_BRANCH_LEN {
            let fork_branch = fork[0..len].to_vec();
            let proposal = proposal_from_blocks(fork_branch);
            verify_proposal_status(
                &mut cached_cip,
                &mut aux_cip,
                &proposal,
                Pending(PendingTopBlock),
            );
        }

        chain_builder.finalize_block(&blocks[2].header.hash());

        for len in 1..=MAX_DATA_BRANCH_LEN {
            let fork_branch = fork[0..len].to_vec();
            let proposal = proposal_from_blocks(fork_branch);
            verify_proposal_status(
                &mut cached_cip,
                &mut aux_cip,
                &proposal,
                Pending(PendingTopBlock),
            );
        }

        chain_builder.finalize_block(&blocks[3].header.hash());

        for len in 1..=MAX_DATA_BRANCH_LEN {
            let fork_branch = fork[0..len].to_vec();
            let proposal = proposal_from_blocks(fork_branch);
            verify_proposal_status(&mut cached_cip, &mut aux_cip, &proposal, Ignore);
        }
        // Proposal below finalized should be ignored
        verify_proposal_status(
            &mut cached_cip,
            &mut aux_cip,
            &proposal_from_blocks(blocks[0..4].to_vec()),
            Ignore,
        );

        // New proposals above finalized should be finalizable.
        let fresh_proposal = proposal_from_blocks(blocks[4..6].to_vec());
        verify_proposal_status(
            &mut cached_cip,
            &mut aux_cip,
            &fresh_proposal,
            Finalize(fresh_proposal.blocks_from_num(0).collect()),
        );

        // Long proposals should finalize the appropriate suffix.
        let long_proposal = proposal_from_blocks(blocks[0..6].to_vec());
        verify_proposal_status(
            &mut cached_cip,
            &mut aux_cip,
            &long_proposal,
            // We are using fresh_proposal here on purpose, to only check the expected blocks.
            Finalize(fresh_proposal.blocks_from_num(0).collect()),
        );
    }
}